hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HTTPCLIENT-806) ConnectException not handled in DefaultHttpMethodRetryHandler
Date Thu, 30 Oct 2008 14:03:44 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-806.
------------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 4.0.1)
                   4.0 Beta 2

Fixed in SVN trunk

Oleg

> ConnectException not handled in DefaultHttpMethodRetryHandler
> -------------------------------------------------------------
>
>                 Key: HTTPCLIENT-806
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-806
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.1 Final
>            Reporter: Jaroslav Bielcik
>             Fix For: 4.0 Beta 2
>
>   Original Estimate: 0.25h
>  Remaining Estimate: 0.25h
>
> Copied from my mailing list post, Oleg suggested I post it to JIRA for 4.0 fix.
> i am using commons-httpclient.3.0.1 and I am sending some requests
> through https protocol. I have a problem with a long creation of
> connection if ip address of remote service is not existing. I think
> problem is in the situation when https connection is not created and
> ConnectException is thrown after connection timeout. This exception is
> catched in HttpMethodDirector.java in method executeWithRetry. Then
> the DefaultHttpMethodRetryHandler is called to recognize whether
> connection creation will be repeated or not.
> I think, that special handling for ConnectException is missing in
> retryMethod of DefaultHttpMethodRetryHandler, because exception is not
> recognized and connetions are created again.
> On the other hand, ConnectTimeoutException is thrown after connection
> timeout for HTTP. This exception is handled in
> DefaultHttpMethodRetryHandler and call is stopped.
> These lines of code handle ConnectTimeoutException in retryMethod of
> DefaultHttpMethodRetryHandler:
> if (exception instanceof InterruptedIOException) {
>             // Timeout
>             return false;
>         }
> Probably this is missing for ConnectException:
> if (exception instanceof InterruptedIOException || exception
> instanceof ConnectException) {
>             // Timeout
>             return false;
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message