Return-Path: Delivered-To: apmail-hc-dev-archive@www.apache.org Received: (qmail 55586 invoked from network); 1 Jul 2008 21:51:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Jul 2008 21:51:30 -0000 Received: (qmail 15860 invoked by uid 500); 1 Jul 2008 21:51:31 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 15827 invoked by uid 500); 1 Jul 2008 21:51:31 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 15816 invoked by uid 99); 1 Jul 2008 21:51:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Jul 2008 14:51:31 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 72.14.220.155 as permitted sender) Received: from [72.14.220.155] (HELO fg-out-1718.google.com) (72.14.220.155) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Jul 2008 21:50:40 +0000 Received: by fg-out-1718.google.com with SMTP id d23so30161fga.32 for ; Tue, 01 Jul 2008 14:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=/0Cd6dKG/BxmW15XzXKZK2HnVnL/5UPTr6uCzR/pRCI=; b=W3cuaGYx/auK4f3yGyZ7C1T9KOiehOgUMbOI+b0G+FSYC1bLHiBkAjWjUkMxeQMdRt D7LkxSpOcS9UyA7SpuPS3bR/zXQ7EYt4z4d9RHjv903OMcbeCYL0XrK0CgfblNVcrhT3 J8Sn87GGOy+OtR6uJ0yMAcQ+Yj7713lI8H2Mk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=Ov2JJVX268awDvlPXFO9qw9bvUC8SECNyPIgmwCrL4XJaLit95EUEh7FWmRbYq2n50 DLCDFXtMNIevbRf/FiE+ynt5ixgIdF4AFSwLUeyQQtovThTqyfufSdeP/H/dbaHn5/58 dAvdcAUbcg5m5qpPubiUBvLvIW/m62z6FOuYM= Received: by 10.86.33.10 with SMTP id g10mr914525fgg.14.1214949058844; Tue, 01 Jul 2008 14:50:58 -0700 (PDT) Received: by 10.86.62.18 with HTTP; Tue, 1 Jul 2008 14:50:58 -0700 (PDT) Message-ID: <25aac9fc0807011450q5e58afe7ref93bb8830644626@mail.gmail.com> Date: Tue, 1 Jul 2008 22:50:58 +0100 From: sebb To: "HttpComponents Project" Subject: Re: svn commit: r673172 - in /httpcomponents/httpclient/trunk: ./ module-client/src/main/java/org/apache/http/client/protocol/ module-client/src/main/java/org/apache/http/impl/client/ module-client/src/main/java/org/apache/http/impl/conn/ module-clie MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org On 01/07/2008, olegk@apache.org wrote: > Author: olegk > Date: Tue Jul 1 11:52:41 2008 > New Revision: 673172 > > URL: http://svn.apache.org/viewvc?rev=673172&view=rev > Log: > HTTPCLIENT-668: removed static loggers > > Modified: > httpcomponents/httpclient/trunk/RELEASE_NOTES.txt > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestAddCookies.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestProxyAuthentication.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestTargetAuthentication.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/ResponseProcessCookies.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/AbstractAuthenticationHandler.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/ClientParamsStack.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/DefaultClientRequestDirector.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/client/DefaultRedirectHandler.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/DefaultClientConnection.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/IdleConnectionHandler.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/SingleClientConnManager.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/AbstractConnPool.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/ConnPoolByRoute.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/RefQueueWorker.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/RouteSpecificPool.java > httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/impl/conn/tsccm/ThreadSafeClientConnManager.java > > Modified: httpcomponents/httpclient/trunk/RELEASE_NOTES.txt > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/RELEASE_NOTES.txt?rev=673172&r1=673171&r2=673172&view=diff > ============================================================================== > --- httpcomponents/httpclient/trunk/RELEASE_NOTES.txt (original) > +++ httpcomponents/httpclient/trunk/RELEASE_NOTES.txt Tue Jul 1 11:52:41 2008 > @@ -1,6 +1,9 @@ > Changes since 4.0 Alpha 4 > ------------------- > > +* [HTTPCLIENT-668] Do not use static loggers > + Contributed by Oleg Kalnichevski > + > * [HTTPCLIENT-781] Respect Keep-Alive header's timeout value. > Contributed by Sam Berlin > > > Modified: httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestAddCookies.java > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestAddCookies.java?rev=673172&r1=673171&r2=673172&view=diff > ============================================================================== > --- httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestAddCookies.java (original) > +++ httpcomponents/httpclient/trunk/module-client/src/main/java/org/apache/http/client/protocol/RequestAddCookies.java Tue Jul 1 11:52:41 2008 > @@ -69,7 +69,7 @@ > */ > public class RequestAddCookies implements HttpRequestInterceptor { > > - private static final Log LOG = LogFactory.getLog(RequestAddCookies.class); > + private transient final Log log = LogFactory.getLog(getClass()); > > public RequestAddCookies() { > super(); > @@ -88,7 +88,7 @@ > CookieStore cookieStore = (CookieStore) context.getAttribute( > ClientContext.COOKIE_STORE); > if (cookieStore == null) { > - LOG.info("Cookie store not available in HTTP context"); > + this.log.info("Cookie store not available in HTTP context"); > return; > } > > @@ -96,7 +96,7 @@ > CookieSpecRegistry registry= (CookieSpecRegistry) context.getAttribute( > ClientContext.COOKIESPEC_REGISTRY); > if (registry == null) { > - LOG.info("CookieSpec registry not available in HTTP context"); > + this.log.info("CookieSpec registry not available in HTTP context"); > return; > } I'm not sure why the loggers were made transient - surely that is only needed if the class is serializable *and* one wishes to avoid changing the serialVersionUID? In which case the readResolve() method needs to be added to ensure that the transient field is initialised (as described in the Wiki). S/// --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org