hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-788) Public Suffix List
Date Wed, 23 Jul 2008 16:00:37 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616134#action_12616134
] 

Sebb commented on HTTPCLIENT-788:
---------------------------------

I'm not entirely sure that it is OK to include the entire Suffix list as test data.
Might be better to create our own test data from the documentation of the format; this would
allow one to add invalid data as well.

Also, one of the method names implies that it only works on Java6 - is that the case, or is
there a fall-back for Java5?

The private boolean readLine(Reader r, StringBuilder sb) method seems a bit unsafe.
As far as I can tell, it does not flush characters to the end of the line, so any characters
after the first white-space will be left for the next call to readLine().

So as far as I can tell,

*.jp comment

would be treated as two lines:

*.jp
comment

The Unicode examples in the testUnicode() method might be better encoded using Unicode escapes,
as is done for the Idn test cases.





> Public Suffix List
> ------------------
>
>                 Key: HTTPCLIENT-788
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-788
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: HttpCookie
>            Reporter: Ortwin Gl├╝ck
>            Priority: Minor
>         Attachments: patch.txt
>
>
> Hi,
> I just found this useful list: http://publicsuffix.org/
> and thought it would be nice to validate cookie domains against it, basically serving
as a black list of domain for which never to set any cookies. What do you think about the
attached patch? The download/parsing of the list is of course not part of the implementation.
> Ortwin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message