hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-770) Code cleanups for Java 1.5 and more.
Date Sat, 03 May 2008 01:28:55 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12593958#action_12593958
] 

Sebb commented on HTTPCLIENT-770:
---------------------------------

Just curious - what's the benefit of using char constants rather than string constants?

> Code cleanups for Java 1.5 and more.
> ------------------------------------
>
>                 Key: HTTPCLIENT-770
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-770
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: Paul Lindner
>            Priority: Minor
>             Fix For: 4.0 Alpha 4
>
>         Attachments: httpclient-cleanups.patch
>
>
> I can't resist giving code a good cleansing when I start hacking.  Here's some simple
things:
> - Use character constants instead of string contstants
> - Use java 1.5 style for loops
> - Use StringBuilder where appropriate
> - Fix javadocs
> - switch somestring.equals("") to .length() == 0
> -  simplify some boolean expressions
> - eliminate redundant initializers
> - fix some html nits
> - remove final keyword from static methods

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message