hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Using Simple Input/Output Buffers with Synapse
Date Sun, 25 May 2008 11:08:36 GMT
On Sun, 2008-05-25 at 01:17 +0530, Asankha C. Perera wrote:
> Hi Oleg


> I also have a question on the Shared buffer class.. in 
> SharedInputBuffer::consumeContent() 
> <http://hc.apache.org/httpcomponents-core/httpcore-nio/xref/org/apache/http/nio/util/SharedInputBuffer.html#80>

> why do you suspendInput if totalRead > 0? This does not mean that the 
> buffer is full.. and we could read more? If I change this condition to " 
> if (totalRead > 0) && !this.buffer.hasRemaining()) " my keep alives 
> "seems" to work.. but I am not sure if this is right or just lucky..


This is clearly a bug. My bad. Many thanks for tracking it down. I
committed the change to the SVN trunk. Could you please re-test Synapse
against the latest SVN snapshot and let me know if the problem still


> thanks
> asankha

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message