Return-Path: Delivered-To: apmail-hc-dev-archive@www.apache.org Received: (qmail 47988 invoked from network); 29 Apr 2008 11:54:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 Apr 2008 11:54:22 -0000 Received: (qmail 58796 invoked by uid 500); 29 Apr 2008 11:54:23 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 58773 invoked by uid 500); 29 Apr 2008 11:54:22 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 58755 invoked by uid 99); 29 Apr 2008 11:54:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Apr 2008 04:54:22 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 74.125.46.152 as permitted sender) Received: from [74.125.46.152] (HELO yw-out-1718.google.com) (74.125.46.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Apr 2008 11:53:37 +0000 Received: by yw-out-1718.google.com with SMTP id 5so2456889ywr.88 for ; Tue, 29 Apr 2008 04:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=ssORK3tUw8PYAW7YUBVvC3S2IV48Mz6nvs2zLA9k3uA=; b=TqvQR7MLQU4vfUtiJ0O5LMOs5e3hjKPNmge8BalcEeHYU2aaEGGertSKgNsqVPyReAGKJZ/Y6UJRsmijtrjNNPk8gmwiXSLfyBweCYM2QcOI3t0k9rs7MInZtkeylFrp4slr8F+0MUgrbLZ4J3AnfeiDo10f2tlB9JgP6FV0osk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=Jb0RlRDRmVPkKur6Z6DwWybzqMV+EjHhIYn7j04qFuaukn0o/j/RzqDfF476Ym5KdWnhn/G9BzlAIrhlB282FPZNFkDCoc7hsYS1gEcmYHxijkqrpTUfa6G4gK8g8yuLPlnJ+vc5aDZq7hy4fVT9bqcMgjyTBW7seHQ1AZTYJfE= Received: by 10.150.49.1 with SMTP id w1mr4902350ybw.25.1209470022479; Tue, 29 Apr 2008 04:53:42 -0700 (PDT) Received: by 10.150.91.10 with HTTP; Tue, 29 Apr 2008 04:53:42 -0700 (PDT) Message-ID: <25aac9fc0804290453r29b732b2kb46274ffab4ceb76@mail.gmail.com> Date: Tue, 29 Apr 2008 12:53:42 +0100 From: sebb To: "HttpComponents Project" Subject: Wrong variable name used in SSLSocketFactory.java? MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org In module-client/src/main/java/org/apache/http/conn/ssl/SSLSocketFactory.java The connectSocket( method has: SSLSocket sslock = (SSLSocket) ((sock != null) ? sock : createSocket()); ... sock.connect(new InetSocketAddress(host, port), connTimeout); // Line 292 sslock.setSoTimeout(soTimeout); ... Looks very much like line 292 should be sslock.connect(new InetSocketAddress(host, port), connTimeout); // Line 292 instead. [Also sslock might be easier to understand if it were named sslsock] [Findbugs reported that sock could be null at 292] S/// --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org