hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Wrong variable name used in SSLSocketFactory.java?
Date Tue, 29 Apr 2008 11:53:42 GMT
In module-client/src/main/java/org/apache/http/conn/ssl/SSLSocketFactory.java

The connectSocket( method has:

        SSLSocket sslock = (SSLSocket)
            ((sock != null) ? sock : createSocket());
...
        sock.connect(new InetSocketAddress(host, port), connTimeout);
// Line 292
        sslock.setSoTimeout(soTimeout);
...

Looks very much like line 292 should be

        sslock.connect(new InetSocketAddress(host, port),
connTimeout); // Line 292

instead.
[Also sslock might be easier to understand if it were named sslsock]

[Findbugs reported that sock could be null at 292]

S///

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message