hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [HttpClient] HttpClient 4.0-alpha4 preview packages
Date Sun, 27 Apr 2008 17:04:57 GMT
2008/4/27 sebb <sebbaz@gmail.com>:
> 2008/4/26 Oleg Kalnichevski <olegk@apache.org>:
>
> > Folks,
>  >
>  >  _Please_ do try to find a few minutes to review the release notes and
>  >  the packages for the coming release.
>  >
>  >  Release notes:
>  >  http://people.apache.org/~olegk/httpclient-4.0-alpha4-preview/RELEASE_NOTES.txt
>  >
>  >  Packages:
>  >  http://people.apache.org/~olegk/httpclient-4.0-alpha4-preview/packages/
>  >
>
>  Not had time to review thoroughly yet, but there are quite a few
>  instances of toLowerCase() - and some of toUpperCase() - which don't
>  specify the Locale.
>
>  These should probably mostly/all use Locale.ENGLISH, otherwise there
>  may be problems in some Locales, e.g. Turkey, where "i".toUpperCase()
>  is not equal to "I" - and vice-versa.
>
>  The isSpecialDomain() method in NetscapeDomainHandler is one instance
>  where the code won't always work in Turkey.
>
>  But given that this is an Alpha Preview, I suppose these fixes could
>  be deferred.
>
>

Two more minor points:
- POM inceptionYear = 2000, but NOTICE says 1999
- junit 3.8.2 would be better than 3.8.1, given that the code does not
need to compile/test on Java 1.3.

>
>  >  Oleg
>  >
>  >
>  >  ---------------------------------------------------------------------
>  >  To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>  >  For additional commands, e-mail: dev-help@hc.apache.org
>  >
>  >
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message