hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-767) Static variables need to be final (or access should be synchronised):
Date Mon, 28 Apr 2008 18:13:55 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592859#action_12592859
] 

Oleg Kalnichevski commented on HTTPCLIENT-767:
----------------------------------------------

Sebastian,
Just commit away. There is no need to open JIRAs for issues like that.

Oleg 

> Static variables need to be final (or access should be synchronised):
> ---------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-767
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-767
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpConn
>         Environment: Current trunk (https://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk
r652021)
>            Reporter: Sebb
>
> Static variables need to be final (or access should be synchronised):
> Index: module-client/src/main/java/org/apache/http/conn/params/HttpConnectionManagerParams.java
> ===================================================================
> --- module-client/src/main/java/org/apache/http/conn/params/HttpConnectionManagerParams.java
(revision 652021)
> +++ module-client/src/main/java/org/apache/http/conn/params/HttpConnectionManagerParams.java
(working copy)
> @@ -53,7 +53,7 @@
>      public static final int DEFAULT_MAX_TOTAL_CONNECTIONS = 20;
>  
>      /** The default maximum number of connections allowed per host */
> -    private static ConnPerRoute DEFAULT_CONN_PER_ROUTE = new ConnPerRoute() {
> +    private static final ConnPerRoute DEFAULT_CONN_PER_ROUTE = new ConnPerRoute() {
>          
>          public int getMaxForRoute(HttpRoute route) {
>              return ConnPerRouteBean.DEFAULT_MAX_CONNECTIONS_PER_ROUTE;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message