hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Wrong variable name used in SSLSocketFactory.java?
Date Tue, 29 Apr 2008 21:28:48 GMT
On Tue, 2008-04-29 at 12:53 +0100, sebb wrote:
> In module-client/src/main/java/org/apache/http/conn/ssl/SSLSocketFactory.java
> 
> The connectSocket( method has:
> 
>         SSLSocket sslock = (SSLSocket)
>             ((sock != null) ? sock : createSocket());
> ...
>         sock.connect(new InetSocketAddress(host, port), connTimeout);
> // Line 292
>         sslock.setSoTimeout(soTimeout);
> ...
> 
> Looks very much like line 292 should be
> 
>         sslock.connect(new InetSocketAddress(host, port),
> connTimeout); // Line 292
> 
> instead.
> [Also sslock might be easier to understand if it were named sslsock]
> 
> [Findbugs reported that sock could be null at 292]
> 

Hi Sebastian

This is clearly a bug. Go ahead and make changes you deem necessary.

Cheers

Oleg



> S///
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message