Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
Subject: Re: httpcore regression?
From: Oleg Kalnichevski <olegk@apache.org>
To: HttpComponents Project <dev@hc.apache.org>
In-Reply-To: <19196d860803071318h3637e1f7k89ad6a2a245cff98@mail.gmail.com>
References: <745369620803061456o79d85e2jd0550d087e720c3b@mail.gmail.com>
	 <1204921099.5871.5.camel@ubuntu>
	 <745369620803071308h622367d5h9045bc3386507c1a@mail.gmail.com>
	 <19196d860803071312p79a02ae4p741856627f8342f6@mail.gmail.com>
	 <745369620803071316n24057e26t9088db230815012@mail.gmail.com>
	 <19196d860803071318h3637e1f7k89ad6a2a245cff98@mail.gmail.com>
Content-Type: text/plain
Date: Fri, 07 Mar 2008 23:34:49 +0100
Message-Id: <1204929289.7768.28.camel@ubuntu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit


On Fri, 2008-03-07 at 16:18 -0500, Sam Berlin wrote:
> Ya, that's basically the reason for the suggestion -- to prevent
> adding a bunch of if!=null checks all over.  Good to know that the
> Async client handler is being used (if only indirectly) !
> 
> Sam
> 

Sam, Andreas

Null checks are cheaper, and I do not think there are going to be that
many of those. Sam, would it be a big deal for you to put together a
patch?

Oleg 


> On 3/7/08, Andreas Andreou <andreoua@gmail.com> wrote:
> > i'm totally clueless on the internals but this suggestion sounds like
> > the null-object pattern and indeed makes sense here (instead of keep finding
> > probable null checking situations)
> >
> > On Fri, Mar 7, 2008 at 11:12 PM, Sam Berlin <sberlin@gmail.com> wrote:
> > > I think the change should be to set an empty entity if none is set but
> > >  the request is an entity-enclosing one, rather not setting one at all.
> > >
> > >  Sam
> > >
> > >
> > >
> > >  On 3/7/08, Andreas Andreou <andreoua@gmail.com> wrote:
> > >  > hmmm - no luck... I now get
> > >  >
> > >  > Exception in thread "IO Reactor Execution Thread" java.lang.NullPointerException
> > >  >        at org.apache.http.nio.protocol.AsyncNHttpClientHandler.outputReady(AsyncNHttpClientHandler.java:222)
> > >  >        at org.apache.http.nio.protocol.BufferingHttpClientHandler.outputReady(BufferingHttpClientHandler.java:110)
> > >  >        at org.apache.http.impl.nio.DefaultNHttpClientConnection.produceOutput(DefaultNHttpClientConnection.java:170)
> > >  >        at org.apache.http.impl.nio.DefaultClientIOEventDispatch.outputReady(DefaultClientIOEventDispatch.java:105)
> > >  >
> > >  > so (unless the above makes sense for you) perhaps i should try and get
> > >  > you a testcase...
> > >  >
> > >  > On Fri, Mar 7, 2008 at 10:18 PM, Oleg Kalnichevski <olegk@apache.org> wrote:
> > >  > >
> > >  > >  On Fri, 2008-03-07 at 00:56 +0200, Andreas Andreou wrote:
> > >  > >
> > >  > >
> > >  > > > Hi list!
> > >  > >  > We've been using httpcore & httpcore-nio
> > >  > >  > 4.0-beta2-20080229.095821-3 but since the new
> > >  > >  > 4.0-beta2-20080303.182830-4 we've been getting (on attempts to request any url)
> > >  > >  > Exception in thread "IO Reactor Execution Thread"
> > >  > >  > java.lang.IllegalArgumentException: wrapped entity must not be null
> > >  > >  >         at org.apache.http.entity.HttpEntityWrapper.<init>(HttpEntityWrapper.java:66)
> > >  > >  >         at org.apache.http.nio.entity.NHttpEntityWrapper.<init>(NHttpEntityWrapper.java:53)
> > >  > >  >         at org.apache.http.nio.protocol.AsyncNHttpClientHandler.requestReady(AsyncNHttpClientHandler.java:156)
> > >  > >  >         at org.apache.http.nio.protocol.AsyncNHttpClientHandler.connected(AsyncNHttpClientHandler.java:109)
> > >  > >  >         at org.apache.http.nio.protocol.BufferingHttpClientHandler.connected(BufferingHttpClientHandler.java:94)
> > >  > >  >         at org.apache.http.impl.nio.DefaultClientIOEventDispatch.connected(DefaultClientIOEventDispatch.java:87)
> > >  > >  >         at com.amplafi.core.iomanagement.http.UniversalIOEventDispatch.connected(UniversalIOEventDispatch.java:102)
> > >  > >  >         at $IOEventDispatch_1187ff96e6e.connected($IOEventDispatch_1187ff96e6e.java)
> > >  > >  >         at $IOEventDispatch_1187ff96e6d.connected($IOEventDispatch_1187ff96e6d.java)
> > >  > >  >         at org.apache.http.impl.nio.reactor.BaseIOReactor.keyCreated(BaseIOReactor.java:182)
> > >  > >  >         at org.apache.http.impl.nio.reactor.AbstractIOReactor.processNewChannels(AbstractIOReactor.java:246)
> > >  > >  >         at org.apache.http.impl.nio.reactor.AbstractIOReactor.execute(AbstractIOReactor.java:153)
> > >  > >  >         at org.apache.http.impl.nio.reactor.BaseIOReactor.execute(BaseIOReactor.java:70)
> > >  > >  >         at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor$Worker.run(AbstractMultiworkerIOReactor.java:318)
> > >  > >  >         at java.lang.Thread.run(Thread.java:619)
> > >  > >  >
> > >  > >  > Does this ring any bells? I've seen a few commits, on 1/3 and 2/3, so
> > >  > >  > i'm wondering if there's something important
> > >  > >  > on those changes.
> > >  > >  >
> > >  > >
> > >  > >  Andreas,
> > >  > >
> > >  > >  I believe I have fixed the problem in trunk and published the latest
> > >  > >  snapshots to the repository. Could you please re-test?
> > >  > >
> > >  > >
> > >  > >
> > >  > >  Cheers,
> > >  > >
> > >  > >  Oleg
> > >  > >
> > >  > >  > TIA
> > >  > >
> > >  > >
> > >  > >  ---------------------------------------------------------------------
> > >  > >  To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > >  > >  For additional commands, e-mail: dev-help@hc.apache.org
> > >  > >
> > >  > >
> > >  >
> > >  >
> > >  >
> > >  > --
> > >  > Andreas Andreou - andyhot@apache.org - http://blog.andyhot.gr
> > >  > Tapestry / Tacos developer
> > >  > Open Source / JEE Consulting
> > >  >
> > >  > ---------------------------------------------------------------------
> > >  > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > >  > For additional commands, e-mail: dev-help@hc.apache.org
> > >  >
> > >  >
> > >
> > >  ---------------------------------------------------------------------
> > >  To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > >  For additional commands, e-mail: dev-help@hc.apache.org
> > >
> > >
> >
> >
> >
> > --
> > Andreas Andreou - andyhot@apache.org - http://blog.andyhot.gr
> > Tapestry / Tacos developer
> > Open Source / JEE Consulting
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org