hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Berlin (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCLIENT-734) request.abort() should interrupt thread waiting for a connection
Date Tue, 18 Mar 2008 17:57:24 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sam Berlin updated HTTPCLIENT-734:
----------------------------------

    Attachment: changes.txt

This patch takes a different approach than the prior one.  Instead of requiring the user of
the ClientConnectionManager to assume that it blocks, an AbortableHttpRequest is now passed
into getConnection.  The ClientConnectionManager must set a ConnectionReleaseTrigger on the
request to support aborting it.

The patch is a little more intrusive than the prior one (in that it touches more classes and
changes some method signatures), but it could be worth it.

There's some more tests in TestTSCCMNoServer to make sure that ThreadSafeClientConnectionManager
is doing the right thing.

(Included in this patch is the small changes & tests for HTTPCLIENT-759, because it's
hard to separate the environments.)

> request.abort() should interrupt thread waiting for a connection
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-734
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-734
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0 Alpha 2
>            Reporter: Roland Weber
>             Fix For: 4.0 Beta 1
>
>         Attachments: changes.txt, changes.txt, connabort.patch
>
>
> Calls to HttpRequestBase.abort() will not unblock a thread that is still waiting for
a connection and therefore has no ConnectionReleaseTrigger yet.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message