hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Berlin (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCLIENT-734) request.abort() should interrupt thread waiting for a connection
Date Wed, 19 Mar 2008 17:02:25 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Sam Berlin updated HTTPCLIENT-734:

    Attachment: changes.txt

Ya, it makes sense.  I took a swipe at using the ClientConnectionRequest approach, and this
is the result.  IMO it's much cleaner than the prior one (which used AbortableHttpRequest)
-- less method signatures changed and the code is simpler to understand.  It still is more
complex than the very first approach, just due to the nature of having to touch more classes...
 but it works very well.

Sorry also for throwing all these patches out so fast -- we're finalizing remaining bugs with
LimeWire, and since we're using httpclient-4.0 now, we need to make sure it's doing what we
expect.  (Don't worry, there's lots of other things to work on too, just not as time-critical.)

> request.abort() should interrupt thread waiting for a connection
> ----------------------------------------------------------------
>                 Key: HTTPCLIENT-734
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-734
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0 Alpha 2
>            Reporter: Roland Weber
>             Fix For: 4.0 Beta 1
>         Attachments: changes.txt, changes.txt, changes.txt, changes.txt, connabort.patch
> Calls to HttpRequestBase.abort() will not unblock a thread that is still waiting for
a connection and therefore has no ConnectionReleaseTrigger yet.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message