Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Message-ID: <28760674.1201967168091.JavaMail.jira@brutus>
Date: Sat, 2 Feb 2008 07:46:08 -0800 (PST)
From: "Oleg Kalnichevski (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Subject: [jira] Commented: (HTTPCLIENT-741) AbstractClientConnAdapter prone
 to concurrency issues
In-Reply-To: <4922665.1201966808189.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565078#action_12565078 ] 

Oleg Kalnichevski commented on HTTPCLIENT-741:
----------------------------------------------

Another major problem is that AbstractClientConnAdapter attempts to release the connection upon invocation of the abort method, which essentially requires the connection manager (or at least its releaseConnection method) to be threading safe. We should not make such assumption. 

Roland

I am going to go ahead and commit fixes for the above problems, given the fact you may be off-line in the coming days / weeks. Please review the changes when you happen to have a chance. If you find anything disagreeable, please let me know.

Oleg

> AbstractClientConnAdapter prone to concurrency issues
> -----------------------------------------------------
>
>                 Key: HTTPCLIENT-741
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-741
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Alpha 2
>            Reporter: Oleg Kalnichevski
>            Priority: Critical
>             Fix For: 4.0 Alpha 3
>
>
> AbstractClientConnAdapter is currently prone to all sorts of concurrency issues. (1) Access to internal state is not properry synchronized making the class prone  to race conditions. Presently none of the instance variables is even declared volatile. (2) AbstractClientConnAdapter treats aborted connection as one in an illegal state, which is not quite right.
> Oleg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org