hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HTTPCLIENT-739) CookieIdentityComparator and CookiePathComparator could/should implement Serializable
Date Mon, 04 Feb 2008 15:54:10 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-739.
------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0 Alpha 3

Fixed in SVN trunk.

Oleg

> CookieIdentityComparator and CookiePathComparator could/should implement Serializable
> -------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-739
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-739
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>            Reporter: Sebb
>             Fix For: 4.0 Alpha 3
>
>
> CookieIdentityComparator and CookiePathComparator could/should implement Serializable
> As Findbugs suggests:
> "Comparator doesn't implement Serializable
> This class implements the Comparator interface. You should consider whether or not it
should also implement the Serializable interface. If a comparator is used to construct an
ordered collection such as a TreeMap, then the TreeMap will be serializable only if the comparator
is also serializable. As most comparators have little or no state, making them serializable
is generally easy and good defensive programming. "
> Neither class has any state, so implementing Serializable would be trivial.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message