hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: [HttpClient] MIME coded HTTP entity code ready for review
Date Mon, 04 Feb 2008 17:36:33 GMT

On Sun, 2008-02-03 at 17:45 +0100, Roland Weber wrote:
> Hi Oleg,
> 
> I haven't had an occasion to look into it yet,
> but here are some observations on a general level.
> 
> module-httpmime
> 
> The name doesn't hit home with me. What's HTTP
> about it?

Hi Roland,

Browser compatibility mode for one. To me, this module is all about HTTP
specific stuff on top of the stock version of mime4j.


>  How about module-mimeentity, or
> module-mimeent to keep the name short?
> 
> org.apache.http.client.mime.MultipartFormHttpEntity;
> 
> What is "client" about it? AFAIK, WebDAV sends
> multipart responses from the server back to the
> client, could the code be used for that as well?
> Change the package to o.a.h.entity.mime, and maybe
> drop the "Form" from the class name? For sake of
> consistency, we should also drop the Http from
> the class name. In HttpCore, we have StringEntity,
> ByteArrayEntity, FileEntity, and InputStreamEntity.
> So let's call this one MultipartEntity or MimeEntity.
> If there's something in the code that ties the
> implementation to the client side, we should work
> on that.
> 

Done.

Oleg


> cheers,
>   Roland
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message