hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: URI created without query
Date Thu, 10 Jan 2008 16:32:36 GMT

On Thu, 2008-01-10 at 17:17 +0100, Johannes Koch wrote:
> Oleg Kalnichevski schrieb:
> > And what about the test case?
> 
> Does it make sense to remove the query
> 
>    "?invk=" + (++this.invocations)
> 
> from the URIs in
> TestRedirects.CircularRedirectService.handle(
>          final HttpRequest request,
>          final HttpResponse response,
>          final HttpContext context)
> 
> ?

It appears so. I checked both patches in. Many thanks, Johannes

Oleg


> plain text document attachment (Patch_TestRedirects_20080110.txt)
> Index: D:/koch/opt/eclipse/workspace_p/httpclient_module-client/src/test/java/org/apache/http/client/protocol/TestRedirects.java
> ===================================================================
> --- D:/koch/opt/eclipse/workspace_p/httpclient_module-client/src/test/java/org/apache/http/client/protocol/TestRedirects.java
(revision 610764)
> +++ D:/koch/opt/eclipse/workspace_p/httpclient_module-client/src/test/java/org/apache/http/client/protocol/TestRedirects.java
(working copy)
> @@ -145,10 +145,10 @@
>              String uri = request.getRequestLine().getUri();
>              if (uri.startsWith("/circular-oldlocation")) {
>                  response.setStatusLine(ver, HttpStatus.SC_MOVED_TEMPORARILY);
> -                response.addHeader(new BasicHeader("Location", "/circular-location2?invk="
+ (++this.invocations)));
> +                response.addHeader(new BasicHeader("Location", "/circular-location2"));
>              } else if (uri.startsWith("/circular-location2")) {
>                  response.setStatusLine(ver, HttpStatus.SC_MOVED_TEMPORARILY);
> -                response.addHeader(new BasicHeader("Location", "/circular-oldlocation?invk="
+ (++this.invocations)));
> +                response.addHeader(new BasicHeader("Location", "/circular-oldlocation"));
>              } else {
>                  response.setStatusLine(ver, HttpStatus.SC_NOT_FOUND);
>              }
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message