hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: [HttpCore] Do away with parameter linking
Date Thu, 10 Jan 2008 12:09:17 GMT

On Thu, 2008-01-10 at 07:25 +0100, ossfwot@dubioso.net wrote:
> > Some details (SPS = SimpleParamStack, CPS = ClientParamsStack):
> > 
> > - SPS constructor expects params in child-parent order, while
> >   CPS constructor expects them in parent-child order
> > - SPS uses "Param" in the name, CPS uses "Params"
> > 
> > I don't care which way these two are done, but it should be consistent.
> 
> Or else you could rename SPS to DefaultedParams and
> getParent() to getDefaults(). This would also prevent 
> confusion with CPS.
> 

Done. Also added some rudimentary documentation of the intended
behaviour. Please review. 

Oleg 



> cheers,
>   Roland
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message