hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pascal S. de Kloe (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-699) Performance tuning
Date Fri, 26 Oct 2007 14:36:50 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537975
] 

Pascal S. de Kloe commented on HTTPCLIENT-699:
----------------------------------------------

> I really wonder what kind of use case creates that many instances of HttpState

How about SOAP?

> It replaces the use of a CookieIdentityComparator with a static method.

It eliminates two class casts within a loop too. Creating a class for 6 lines of code if it
is only used once doesn't seem right.

> I can't see any savings in the changes to getCookies().

Again, a class cast.


None of these changes are major but if you accept them I'll go through the whole codebase
and improve things bit by bit. That is the way I usually work.


> Performance tuning
> ------------------
>
>                 Key: HTTPCLIENT-699
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-699
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0 Alpha 1
>            Reporter: Pascal S. de Kloe
>            Priority: Minor
>         Attachments: HttpState.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message