hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roland Weber (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-126) Improved HTTP message parsing
Date Sun, 28 Oct 2007 10:24:51 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538301
] 

Roland Weber commented on HTTPCORE-126:
---------------------------------------

Hi Oleg,

looks good. Please merge the changes back into trunk.

In BasicHeaderValueParser, the PARAM_DELIMITER and ELEM_DELIMITER should either be constant
(static final) or protected to allow modification.
I'd feel better if ParserCursor.atEnd used >= instead of ==. I've seen that the bounds
are checked in updatePos(...), but it was one of the golden rules I learned in the first semester
at the university: don't use equality operators for range checks :-)

cheers,
  Roland


> Improved HTTP message parsing
> -----------------------------
>
>                 Key: HTTPCORE-126
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-126
>             Project: HttpComponents Core
>          Issue Type: Improvement
>    Affects Versions: 4.0-alpha6
>            Reporter: Oleg Kalnichevski
>             Fix For: 4.0-beta1
>
>         Attachments: http-parser.patch
>
>
> Implement a more flexible HTTP message parsing API that eliminates the need to skip back
during the parsing process thus potentially improving performance.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message