Mailing-List: contact httpcomponents-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <httpcomponents-dev@jakarta.apache.org>
Received-SPF: pass (herse.apache.org: domain of odi@odi.ch designates
 62.65.128.36 as permitted sender)
Message-ID: <46879416.20909@odi.ch>
Date: Sun, 01 Jul 2007 13:46:30 +0200
From: =?ISO-8859-1?Q?Ortwin_Gl=FCck?= <odi@odi.ch>
User-Agent: Thunderbird 2.0.0.4 (X11/20070616)
MIME-Version: 1.0
To: HttpComponents Project <httpcomponents-dev@jakarta.apache.org>
Subject: Re: [HttpClient][PATCH] Version detection
References: <1183289425.1843.17.camel@okhost>
In-Reply-To: <1183289425.1843.17.camel@okhost>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit


Oleg Kalnichevski wrote:
> Roland et al
> 
> There is my first stab at version detection based on build-time
> properties. Maven will happily filter resource files and replace
> property placeholders with their corresponding build-time values. I am
> not sure the same can be done for source files. So, the downside of this
> approach is that the resource file containing the version needs to be
> loaded through a class loader. Oh well. I am not sure this will pass the
> scrutiny of the Holy API Inquisition but I'll try ;-)
> 
> Cheers
> 
> Oleg

I quite like the version file. Also the class naming is consistent with Version
classes used by other projects. Maybe the version file could be a property file?
 I know Maven/Ant can easily update those. And it would give a little extra
safety regarding encoding.

Odi

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org