hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: svn commit: r554708
Date Tue, 10 Jul 2007 11:00:34 GMT
On Tue, 2007-07-10 at 11:09 +0200, Roland Weber wrote:
> olegk@apache.org wrote:
> > Log:
> > Keep RAT happy
> 
> I wonder whether we really should in this case.
> The properties file(s) will be parsed at runtime.
> Not too often, but still.
> 
> cheers,
>   Roland
> 

Hi Roland

I am afraid this is one of those marvelous ASF policies we have no
choice but to comply with. Besides, I don't think the performance impact
is significant. The whole damn thing _should_ end up in the input buffer
on the first read, so the most expensive operation is going to be
opening the file and filling the input buffer anyways, not line
tokenization. No to mention VersionInfo is not meant to be invoked
anywhere on a critical execution path so optimizing it just does not
seem to be worth the trouble.   

Oleg


> > +++ jakarta/httpcomponents/httpclient/trunk/module-client/src/main/resources/org/apache/http/client/version.properties
Mon Jul  9 09:58:33 2007
> > @@ -1 +1,20 @@
> > +#
> > +# Licensed to the Apache Software Foundation (ASF) under one
> > +# or more contributor license agreements.  See the NOTICE file
> > +# distributed with this work for additional information
> > +# regarding copyright ownership.  The ASF licenses this file
> > +# to you under the Apache License, Version 2.0 (the
> > +# "License"); you may not use this file except in compliance
> > +# with the License.  You may obtain a copy of the License at
> > +#
> > +#   http://www.apache.org/licenses/LICENSE-2.0
> > +#
> > +# Unless required by applicable law or agreed to in writing,
> > +# software distributed under the License is distributed on an
> > +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> > +# KIND, either express or implied.  See the License for the
> > +# specific language governing permissions and limitations
> > +# under the License.    
> > +#
> > +
> >  httpclient.release=${pom.version}
> > 
> > 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message