hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steffen Pingel (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCORE-73) Add notification to NHttpServiceHandler when response has been sent
Date Wed, 16 May 2007 16:28:16 GMT

     [ https://issues.apache.org/jira/browse/HTTPCORE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Steffen Pingel updated HTTPCORE-73:
-----------------------------------

    Attachment: httpcore-nio-request-ready.patch

Oleg, I changed my implementation to use the responseReady() event but some of my test cases
failed because the event was not always fired. When a response has no body DefaultNHttpServerConnection.produceOutput()
will flush outbuf and then clear write events causing it to not get called again. Please see
the attached patch for a fix.

Thanks again for all your efforts! With the latest changes I have been able to integrate an
unmodified version (except for this patch) of httpcore in my application for handling of HTTP
requests which clearly demonstrates the flexibility and versatility of the API.

> Add notification to NHttpServiceHandler when response has been sent
> -------------------------------------------------------------------
>
>                 Key: HTTPCORE-73
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-73
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore NIO
>    Affects Versions: 4.0-alpha5
>            Reporter: Steffen Pingel
>         Attachments: httpcore-nio-request-ready.patch
>
>
> Add a new method to NHttpServiceHandler that notifies the service handler that a response
has been sent: 
> void responseSubmitted(NHttpServerConnection conn); 
> The sent response can be retrieved through conn.getHttpResponse() when the method is
invoked. The use case here is that I need to enable and disable throttling per response (which
is handled by the underlying NIO layer) and need to know at what point the output buffer for
a response has been flushed. The throttling is controlled in the application layer so I need
to propagate the event through the layers. 
> Such an event notification could also replace NHttpServerConnection.isResponseSubmitted()
which currently has an implementation in DefaultNHttpServerConnection that does not match
the JavaDoc specification.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message