hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roland Weber <ossf...@dubioso.net>
Subject Re: svn commit: r537590 - in /jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http: conn/ssl/SSLSocketFactory.java impl/client/DefaultClientRequestDirector.java impl/conn/DefaultClientConnection.java
Date Sun, 13 May 2007 16:30:50 GMT
Hi Oleg,

> --- jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/impl/client/DefaultClientRequestDirector.java
(original)
> +++ jakarta/httpcomponents/httpclient/trunk/src/java/org/apache/http/impl/client/DefaultClientRequestDirector.java
Sun May 13 07:46:12 2007
> +        if (port < 0) {
> +            SchemeRegistry schemeREgistry = connManager.getSchemeRegistry();
> +            Scheme scheme = schemeREgistry.getScheme(target.getSchemeName());
> +            port = scheme.getDefaultPort();
> +        }

Just the capitalization of the variable. Is it necessary
to have the variable at all, if there is no null check?

cheers,
  Roland


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message