Mailing-List: contact httpcomponents-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <httpcomponents-dev@jakarta.apache.org>
Message-ID: <26696316.1177779975561.JavaMail.jira@brutus>
Date: Sat, 28 Apr 2007 10:06:15 -0700 (PDT)
From: "Roland Weber (JIRA)" <jira@apache.org>
To: httpcomponents-dev@jakarta.apache.org
Subject: [jira] Updated: (HTTPCLIENT-650) Wire log is incomplete if
 HttpParser detects an error
In-Reply-To: <32838754.1177763655523.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HTTPCLIENT-650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roland Weber updated HTTPCLIENT-650:
------------------------------------

    Attachment: 2k7-04-28-wire-log.txt

Sebastian, thanks a lot for figuring this out. The situation is indeed even a bit worse, because what is logged is not the actual input from the wire, but what is returned by the parser. That's after stripping ignorable whitespace and concatenating continuation lines.
Attached patch moves wire logging for headers (but not for the status line) from HttpMethodBase to HttpParser.readLine(...). Somebody please review this _carefully_. I know it compiles, but I don't have the environment set up to test whether it actually logs as expected...

cheers,
  Roland


> Wire log is incomplete if HttpParser detects an error
> -----------------------------------------------------
>
>                 Key: HTTPCLIENT-650
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-650
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.1 RC1
>            Reporter: Sebb
>            Priority: Minor
>         Attachments: 2k7-04-28-wire-log.txt
>
>
> If HttpParser detects an error in any of the headers, it throws a ProtocolException
> Although the failing header is included in the Exception detail, the headers leading up to the failure are not logged, which makes it hard to debug (and is quite confusing, as the PE does not appear to be related to the data that has been received).
> This is because the wire-logging is done in the caller (HttpMethodDirector) which only logs the header if the parse succeeds.
> Perhaps the Wire logging should be done at the point where the HttpParser reads the line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org