hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Asankha C. Perera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-49) DefaultConnectingIOReactor does not properly handle failures
Date Sat, 03 Mar 2007 20:05:50 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477675
] 

Asankha C. Perera commented on HTTPCORE-49:
-------------------------------------------

Hi Oleg

Yes, you are right and that was the only thing I actually needed as well. I tested the patch
and it seems fine. Could you kick off a maven build and upload once you commit this patch.
I will make necessary changes on our side to be in sync with your latest revision

many thanks
asankha

> DefaultConnectingIOReactor does not properly handle failures
> ------------------------------------------------------------
>
>                 Key: HTTPCORE-49
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-49
>             Project: HttpComponents Core
>          Issue Type: Bug
>          Components: HttpCore NIO
>            Reporter: Asankha C. Perera
>         Assigned To: Oleg Kalnichevski
>            Priority: Critical
>             Fix For: 4.0-alpha4
>
>         Attachments: connect.patch
>
>
> The DefaultConnectingIOReactor uses SocketChannel.connect() which could throw a runtime
exception such as an UnresolvedAddressException, that does not get handled
> try {
>                 if (request.getLocalAddress() != null) {
>                     socketChannel.socket().bind(request.getLocalAddress());
>                 }
>                 socketChannel.connect(request.getRemoteAddress());
>             } catch (IOException ex) {
>                 request.failed(ex);
>             }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message