hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-59) AbstractIOReactor.processNewChannels calls SessionRequest.completed
Date Thu, 15 Mar 2007 21:30:09 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12481325

Oleg Kalnichevski commented on HTTPCORE-59:

> I don't know why a SessionRequest is considered completed after the connection is established.
> I would think that a request is completed after the response has been received

SessionRequest is meant to represent a request for a new _session_ (or connection in the HTTP
terms), right? New IOSession instance basically represents the result of this operation and
a callback on the SessionRequestCallback interface represents the response. One is supposed
to call SessionRequest#cancel() to abort the process of establishing a new connection (for
instance when it takes too long), and not to cancel an individual request sent over the connection.
Does this somehow make things a little clearer?


> AbstractIOReactor.processNewChannels calls SessionRequest.completed
> -------------------------------------------------------------------
>                 Key: HTTPCORE-59
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-59
>             Project: HttpComponents Core
>          Issue Type: Bug
>          Components: HttpCore NIO
>    Affects Versions: 4.0-alpha4
>         Environment: Windows Vista
>            Reporter: Anders Wallgren
> SessionRequest.completed is called from AbstractIOReactor.processNewChannels -- this
doesn't make any sense to me.
> (As a side-note, the dearth of javadoc and comments in the code makes it challenging
to figure this out.)

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org

View raw message