hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-39) refactor HttpStatus
Date Sat, 10 Feb 2007 18:52:05 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472012
] 

Oleg Kalnichevski commented on HTTPCORE-39:
-------------------------------------------

Hi Roland,

I think it is rather unfortunate we dragged the whole localization story into Core, but since
we did it, we should at the very least be consistent and put setLocale() and getLocale methods
to the HttpMessage interface, and mot just HttpResponse. At some point of time we also may
want to add request interceptors to set the locale for HTTP requests.

I can live with the patch. Please go ahead and commit

Oleg

> refactor HttpStatus
> -------------------
>
>                 Key: HTTPCORE-39
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-39
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha3
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>            Priority: Minor
>             Fix For: 4.0-alpha4
>
>         Attachments: 2k7-02-03-HttpStatus.txt, 2k7-02-04-status-followup.txt, 2k7-02-06-impl-catalog.txt,
2k7-02-10-status-followup.txt
>
>
> The HttpStatus class not only represents a status code with associated message, it also
has static factory methods for creating objects with hard-coded english status messages. Suggested
improvements:
> - define HttpStatusFactory in the API
> - move the factory method stuff to impl, for example EnglishHttpStatusFactory
> - reduce HttpStatus class to representation only, final and serializable
> patch to follow when I find the time
> cheers,
>   Roland

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message