hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roland Weber (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-634) HostConfiguration socketFactory is ignored
Date Mon, 19 Feb 2007 15:21:09 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474199
] 

Roland Weber commented on HTTPCLIENT-634:
-----------------------------------------

I'm +1 on the one-line change in HttpClient. The HostProtocolConfiguration could go into contrib
code, though we'd have to find a name that better indidcates the purpose.
I'm -1 on putting HostProtocolConfiguration into the main code, even with a better name. If
we start with that, next thing will be a subclass of HostConfiguration that overrides the
host, and then one that overrides protocol and host,... It's good as an example, but not as
code we have to maintain.

cheers,
  Roland


> HostConfiguration socketFactory is ignored
> ------------------------------------------
>
>                 Key: HTTPCLIENT-634
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-634
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: Nightly Builds
>         Environment: Windows, Eclipse, Java 1.5
>            Reporter: John Kristian
>            Priority: Minor
>             Fix For: 3.1 RC1
>
>         Attachments: HostConfiguration.patch, HostProtocolConfiguration.patch
>
>
> HostConfiguration doesn't use its host.protocol to execute an HttpMethod with an absolute
URL.  It should, if the Protocol's scheme is the same as the method's URL scheme.
> This bug makes it difficult to integrate a specialized SSL connection algorithm (in a
SecureProtocolSocketFactory) with a module implemented on top of HttpClient.  The latter module
must not execute methods with absolute URLs.  Of course, this is difficult when one doesn't
control that module.  For example, I recently tried to integrate SSL certificate-based client
authentication with XFire.  XFire provides a reasonable API for replacing its HttpClient,
but one must hack its source code to prevent it from executing methods with absolute URLs.
> Protocol.registerProtocol is a possible answer, but it can't support two or more SSL
connection algorithms for one HTTPS host and port.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message