hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roland Weber (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-32) provide interface to manipulate interceptor lists
Date Mon, 29 Jan 2007 16:13:49 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468320
] 

Roland Weber commented on HTTPCORE-32:
--------------------------------------

Hi Oleg,

BasicHttpProcessor is stuck in transition. We changed the underlying collection from Set to
List to maintain order, but we didn't update the interface. I always considered that one of
the things I'd do when I get to it, and now seems to be the time. The deficiency has not been
noticed yet because nobody cares (needs?) to modify interceptor order programmatically: the
list is built once and remains unchanged afterwards.
We can declare this to be the usage model of choice for BasicHttpProcessor, in that case I
suggest to get rid of the removeInterceptor methods. But if we have methods to manipulate
the list, I feel we should give the user full control over the interceptor order.

I can define interfaces and implementation in HttpClient and we'll discuss folding them into
HttpCore afterwards.

cheers,
  Roland


> provide interface to manipulate interceptor lists
> -------------------------------------------------
>
>                 Key: HTTPCORE-32
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-32
>             Project: HttpComponents Core
>          Issue Type: New Feature
>          Components: HttpCore
>    Affects Versions: 4.0-alpha3
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>            Priority: Minor
>
> HttpClient interface should expose the lists of request and response interceptors in
an HttpProcessor to allow for programmatic modification. Currently, there is no interface
that allows for modification, only the implementation class BasicHttpProcessor. Interfaces
should be defined in HttpCore rather than HttpClient so they can be implemented directly by
BasicHttpProcessor. Suggested names:
> HttpRequestInterceptorList
> HttpResponseInterceptorList
> cheers,
>   Roland

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message