Return-Path: Delivered-To: apmail-jakarta-httpcomponents-dev-archive@www.apache.org Received: (qmail 40472 invoked from network); 12 Dec 2006 11:36:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Dec 2006 11:36:45 -0000 Received: (qmail 29222 invoked by uid 500); 12 Dec 2006 11:36:53 -0000 Delivered-To: apmail-jakarta-httpcomponents-dev-archive@jakarta.apache.org Received: (qmail 29191 invoked by uid 500); 12 Dec 2006 11:36:53 -0000 Mailing-List: contact httpcomponents-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list httpcomponents-dev@jakarta.apache.org Received: (qmail 29182 invoked by uid 99); 12 Dec 2006 11:36:52 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2006 03:36:52 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Dec 2006 03:36:44 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id DF3AD714057 for ; Tue, 12 Dec 2006 03:36:23 -0800 (PST) Message-ID: <15160108.1165923383911.JavaMail.jira@brutus> Date: Tue, 12 Dec 2006 03:36:23 -0800 (PST) From: "Oleg Kalnichevski (JIRA)" To: httpcomponents-dev@jakarta.apache.org Subject: [jira] Commented: (HTTPCLIENT-614) allow different strategies when checking CN of x509 cert In-Reply-To: <17456851.1165592721718.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/HTTPCLIENT-614?page=comments#action_12457673 ] Oleg Kalnichevski commented on HTTPCLIENT-614: ---------------------------------------------- Julius, Would it be possible to get rid of dependency on commons-codec, especially if it is only needed to run test cases? I personally would prefer to move all HostnameVerifier impls to o.a.http.conn.impl package. HostnameVerifier.DEFAULT and friends should probably be better off moved to an object factory of a sort. I'll review the patch more thoroughly tomorrow and check it in to the SVN trunk Oleg > allow different strategies when checking CN of x509 cert > -------------------------------------------------------- > > Key: HTTPCLIENT-614 > URL: http://issues.apache.org/jira/browse/HTTPCLIENT-614 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpConn > Affects Versions: Nightly Builds > Reporter: Julius Davies > Fix For: 4.0 Alpha 1 > > Attachments: ssl.patch > > > We're now doing a decent job for checking the CN of the x509 cert with https: > http://issues.apache.org/jira/browse/HTTPCLIENT-613 > I think the patch for HTTPCLIENT-613 should cover 99.9% of the users out there. But there are some more esoteric possibilities, so I think Oleg is right. We need to let the user change the strategy, or provide their own strategy if they want to. > Some additional things to think about: > - http://wiki.cacert.org/wiki/VhostTaskForce !!! CN is depreciated?!?! (I am not able to find a popular website on HTTPS that isn't using CN!) > - [*.example.com] matches subdomains [a.b.example.com] on Firefox, but not IE6. The patch for HTTPCLIENT-613 allows subdomains. > - Should we support multiple CN's in the subject? > - Should we support "subjectAltName=DNS:www.example.com" ? Should we support lots of them in a single cert? > - Should we support a mix of CN and subjectAltName? > If we do create some alternate strategies for people to try, I'd probably lean towards something like this: > X509NameCheckingStrategy.SUN_JAVA_6 (default) > X509NameCheckingStrategy.FIREFOX2 > X509NameCheckingStrategy.IE7 > X509NameCheckingStrategy.FIRST_CN_AND_NO_WILDCARDS (aka "STRICT") -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org