hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-610) HttpMethodBase.getResponseBodyAsString(long limit)
Date Fri, 01 Dec 2006 10:31:22 GMT
    [ http://issues.apache.org/jira/browse/HTTPCLIENT-610?page=comments#action_12454870 ] 
            
Oleg Kalnichevski commented on HTTPCLIENT-610:
----------------------------------------------

We should apply the same logic as in #getResponseBody method at the very least for the consistency
sake:

ByteArrayOutputStream outstream = new ByteArrayOutputStream(
  contentLength > 0 ? (int) contentLength : DEFAULT_INITIAL_BUFFER_SIZE);

Otherwise +1 to commit

Oleg

> HttpMethodBase.getResponseBodyAsString(long limit)
> --------------------------------------------------
>
>                 Key: HTTPCLIENT-610
>                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-610
>             Project: HttpComponents HttpClient
>          Issue Type: Wish
>    Affects Versions: 3.1 Alpha 1
>            Reporter: Stepan Koltsov
>         Assigned To: Ortwin Gl├╝ck
>            Priority: Trivial
>         Attachments: patch-take2.txt
>
>
> Currently HttpMethodBase.getResponseBodyAsString() prints warning in log, and suggests
using getResponseStream(). However getResponseBodyAsString() is extremely useful (as it is
easy to use). So my wish is to have method
> getResponseBodyAsString(long limit)
> that should throw HttpException if response size exceeds specified limit.
> Same things with getResponseBody(long limit) .
> Original methods should be deprecated because of danger, explained in javadoc.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message