hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Endre Stølsvik (JIRA) <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-609) Use TRACE logging instead of DEBUG for the absolute nitty-gritties
Date Wed, 29 Nov 2006 13:56:22 GMT
    [ http://issues.apache.org/jira/browse/HTTPCLIENT-609?page=comments#action_12454311 ] 
            
Endre Stølsvik commented on HTTPCLIENT-609:
-------------------------------------------

@Roland: I don't quite see what you're answering/commenting - did you read the entire description?!

I did NOT at ANY POINT say that you should stop using DEBUG: I've however not seen a single
log-line from httpclient that outputs on TRACE. (Full wire-dump doesn't belong in DEBUG, IM(F)O)

In my description, I try to point out that I'd appreciate IF you DID use TRACE "somewhat more
extensively" (given that it isn't used at all now, AFAICS).

And I came up with some quick candidates for which loglines that would be better sent to TRACE
than DEBUG.

Given that I do not suggest that you delete one single log-statement, only "downgrade" some
loglines from DEBUG to TRACE, I do not understand where you're coming from in your comment
at all.

Also, I firmly believe that you folks should think of "the developers" not as yourself, but
as the users of your library. There are many more of the latter than the former. However,
given, again, that I do not suggest that you delete one single logline, I can't seem to get
why not both camps could be pleased in this particular situation.

> Use TRACE logging instead of DEBUG for the absolute nitty-gritties
> ------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-609
>                 URL: http://issues.apache.org/jira/browse/HTTPCLIENT-609
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 3.1 Beta 1
>         Environment: n/a
>            Reporter: Endre Stølsvik
>            Priority: Minor
>             Fix For: 4.0 Alpha 1
>
>
> [This is basically a copy of the Spring improvement request SPR-2873: http://opensource.atlassian.com/projects/spring/browse/SPR-2873
)
> Given a developer situation: Much of the DEBUG information in the log of HttpClient is
very un-interesting as long as it works. Some of these lines are however of much bigger importance
than others (thus turning off DEBUG globally for HttpClient isn't good either).
> TRACE and DEBUG are the two developer-centric logging levels of log4j and commons logging
(the rest are "production levels"). Since log4j-1.2.12, TRACE have existed. Clogging have
always had trace, but before release 1.1 mapped Log.trace to log4j's DEBUG, but 1.1 (released
May 9. 2006) now maps to log4j's TRACE.
> I think that HttpClient's logging would benefit a lot by using TRACE level extensively,
in that developers could turn all of httpclient's logging down to DEBUG, but still see "major
developer events" like connections being opened, the request being sent, and e.g. the response's
status line, size of headers and body, keep-alive vs. closing of connection.
> Candidates for TRACE level include:
>   * httpclient.wire.*
>   * org.apache.commons.httpclient.params.DefaultHttpParams
>   * org.apache.commons.httpclient.HttpMethodBase
>   * .. and probably a bunch of others that doesn't bring the developer in the standard
"good flow mode" any highly interesting information. 
> Please note that I do NOT view these lines as worthless. It is however in _normal_ developer
circumstances not valuable information, and it would ease development if it was possible to
turn these ultra-verbose loglines off easily. When things just aren't working out, and your
exciting REST-based query doesn't work out, or your charset encodings just doesn't give what
you're expecting, you'd turn on TRACE to really get down to the hard core. You'd find the
problem, fix it, and set it to DEBUG again.
> In addition, the lines that were left on the DEBUG level should obviously be as informative
as possible, and thus maybe somewhat more verbose than now, trying to "aggregate" some pieces
of information that now are output over several DEBUG lines..
> I do realize that I could achive a lot of this with a rather extensive log configuration,
that also had to include raw text filters, but I do believe that this affects more developers
than me!
> PS: it wouldn't hurt either if all of httpclient's log-lines came from a common root,
e.g. "HttpClient", or "org.apache.commons.httpclient", instead of having several roots. This
would however be a somewhat "backward incompatible" change, since it now has (at least?) two
roots.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org


Mime
View raw message