hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Roland Weber <http-as...@dubioso.net>
Subject Re: [jira] Updated: (HTTPCORE-11) [3rd patch]
Date Tue, 05 Sep 2006 12:56:06 GMT
Hi Oleg,

I had a quick look and will share my initial thoughts here. Maybe I'll think
differently after chewing on this for a while. Or maybe you can add some
ideas of yours in response.

(1) agreed. I hadn't seen that point before.

(2) A connection manager (and/or operator) is responsible for more than one
connection. Per-connection information is best kept with the connection
itself. I don't see why the information shouldn't be publicly accessible in a
read-only fashion. It allows for the implementation of strategies that are
not tied to a specific connection manager (or whatever) implementation.
Such as "don't keep connections to host XYZ alive".

(3) agreed

Two weeks ago we discussed turning the connections into simple containers
that don't know how to establish a connection. While your patch does achieve
that, it also effectively turns connections into throw-away objects. On first
thought, I don't like it because of a gut feeling. On second thought I don't
like it because SimpleHttpDispatcher assumes to have *one* connection which
can be pointed to different targets one after another. It's probably not hard
to change, but throw-away connection objects clash with every thought about
"connection management" I've ever had so far.

cheers,
  Roland


---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message