hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roland Weber (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-13) AbstractHttpProcessor is not really abstract
Date Tue, 26 Sep 2006 18:47:54 GMT
    [ http://issues.apache.org/jira/browse/HTTPCORE-13?page=comments#action_12437906 ] 
            
Roland Weber commented on HTTPCORE-13:
--------------------------------------

Hi Oleg,

I kind of feel that HttpProtocolHandler does not give the slightest indication what the class
is supposed to do.
I liked the HttpInterceptorChain suggestion better. When I worked on the patch I also considered
HttpMessageProcessor.
HTTP protocol handling is much more than just setting up or interpreting a few headers. Of
course,
processing is also a very generic term. Some clicks on WordNet (http://wordnet.princeton.edu/perl/webwn)
lead me to "shape" or "mould" as alternatives to indicate that the purpose is to bring a message
into a
particular form suitable for the following step. HttpMessageShaper? HttpMessageSculptor? ;-)
HttpMessageFilter is probably misleading.

cheers,
  Roland



> AbstractHttpProcessor is not really abstract
> --------------------------------------------
>
>                 Key: HTTPCORE-13
>                 URL: http://issues.apache.org/jira/browse/HTTPCORE-13
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha3
>            Reporter: Roland Weber
>         Assigned To: Roland Weber
>            Priority: Minor
>         Attachments: 2k6-09-25-core-proc-1.txt
>
>
> AbstractHttpProcessor is declared abstract though it does not have any abstract method.
This artificially restricts use of the base class functionality to subclassing and prohibits
use by reference. That is one of the reasons why HttpAsync has an ugly AsyncHttpProcessor
class.
> Patch follows.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message