hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: svn commit: r437358
Date Sun, 27 Aug 2006 11:17:35 GMT
On Sun, 2006-08-27 at 13:14 +0200, Roland Weber wrote:
> Hi Oleg,
> 
> just a few minor observations:
> 
> EventMask: unless you're going to add more, this should either
> be an interface or have the default constructor disabled.
> 

Good point.

> IOSession: the get/set/removeAttribute methods look exactly
> like those in HttpContext. Derive the session from the context?
> 

Good point.

> No JavaDoc warnings ;-)
> 

No javadocs - no javadocs warnings ;-)

Oleg

> cheers,
>   Roland
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message