hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37988] - UserInfo disapears after creating URI
Date Wed, 22 Mar 2006 13:56:59 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37988>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37988





------- Additional Comments From asf-bugzilla@tommym.net  2006-03-22 13:56 -------
Created an attachment (id=17942)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17942&action=view)
patch to add authority to httphost

> No, it should not. HttpClient is not supposed to implement FTP specific
concerns. 
> 
> Feel free to extend the standard GetMethod class and override the default
> behaviour of the #writeRequestLine() method the way we deem appropriate for
your
> specific application.
> 
> Oleg

Thanks for you reaction, but I tend to disagree. This is not ftp specific, but
host specific (i.e. the host to connect to). Besides, by registering another
protocol with Protocol.registerProtocol(...) it is already possible to use
non-http-like protocols.

The authority is a part of a host (in this case a httphost using the ftp
protocol), just the same as it is a part of the URL. This patch adds the
authority to the HttpHost.

I think that the following HTTP requestline is valid:
GET http://user:pass@host/file.html HTTP/1.1

Therefore I think the following should be valid too:
GET ftp://user:pass@host/file.html HTTP/1.1

I hope you can see my point. If not, at least I have a patch locally.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message