hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 38279] - define API for http-async
Date Sun, 05 Feb 2006 03:41:07 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=38279>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=38279





------- Additional Comments From becke@u.washington.edu  2006-02-05 04:41 -------
Overall I think it looks quite good.  The code is well designed and clearly
documented.  Nice work Roland!

Only one major thing came to mind as I was looking over the code.  This design
seems to rely on polling/waiting for handling responses due to
HttpHandle.awaitResponse().  My first inclination would be to instead use
callbacks to handle the responses, therefore allowing responses to be processed
in the order they are ready as opposed to when they are requested.  For the
current implementation it doesn't really matter as there is only one dispatch
thread, but I'm guessing that if we were to add more threads or use NIO we would
want truly asynchronous response handling.

Another small thing I noticed was the copyright statement lists 1999-2006, for
this code it should just be 2006.

Mike

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message