hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 37939] - Decouple control logic (expect-continue handshake, etc) from HttpClientConnection
Date Fri, 16 Dec 2005 19:14:35 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37939>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37939





------- Additional Comments From olegk@apache.org  2005-12-16 20:14 -------
Created an attachment (id=17233)
 --> (http://issues.apache.org/bugzilla/attachment.cgi?id=17233&action=view)
Patch (take 1)

Roland, 
I hope this takes care of the problem. The new HttpClientConnection interface
looks like that:

...
void sendRequest(HttpRequest request) throws HttpException, IOException;
void sendRequestHeader(HttpEntityEnclosingRequest request) throws
HttpException, IOException;
void sendRequestEntity(HttpEntityEnclosingRequest request) throws
HttpException, IOException;
HttpResponse receiveResponse(HttpParams params) throws HttpException,
IOException;
HttpResponse receiveResponse(HttpParams params, int timeout) throws
HttpException, IOException;
...

which *should* cover all the use cases I can think of at the moment. 

The patch completely decouples the 'expect: continue' logic from the
HttpClientConnection interface and its default impl and moves it into the HTTP
request executor class

Please review and let me know what you think

Oleg

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message