hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 35365] - No equals operation for Credentials implementations
Date Wed, 15 Jun 2005 07:13:38 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=35365>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=35365





------- Additional Comments From rolweber@de.ibm.com  2005-06-15 09:13 -------
Hello Eric,

my first thought was that credentials should not be comparable, since that
might be a way for an attacker to obtain secret information. But since our
credentials return the password anyway, having an implementation for equals
really doesn't harm.

Code looks good to me. Maybe add a hint in the JavaDocs for equals() that
host name comparison is case sensitive? (I assume it is.)

cheers,
  Roland


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpclient-dev-help@jakarta.apache.org


Mime
View raw message