hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 21329] - Add InputStream buffering.
Date Wed, 29 Sep 2004 21:49:31 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=21329>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=21329

Add InputStream buffering.





------- Additional Comments From eric@tibco.com  2004-09-29 21:49 -------
Close, but not quite - what if the readLimit on the mark() call has been exceeded?

A simpler way to fix this would be to simply return "false" for markSupported(),
and not pass the mark function through, and throw an exception on reset.  Or, in
the alternative, have ContentLengthInputStream extend BufferedInputStream
instead of FilterInputStream, and then rely on the protected members of
BufferedInputStream, rather than duplicating the same logic.

I'm willing to submit a patch for either choice, but I can't decide which one is
better.  Anyone?

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message