Return-Path: Delivered-To: apmail-jakarta-commons-httpclient-dev-archive@www.apache.org Received: (qmail 41832 invoked from network); 3 Jul 2004 21:27:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 3 Jul 2004 21:27:40 -0000 Received: (qmail 18335 invoked by uid 500); 3 Jul 2004 21:27:42 -0000 Delivered-To: apmail-jakarta-commons-httpclient-dev-archive@jakarta.apache.org Received: (qmail 18277 invoked by uid 500); 3 Jul 2004 21:27:41 -0000 Mailing-List: contact commons-httpclient-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Commons HttpClient Project" Reply-To: "Commons HttpClient Project" Delivered-To: mailing list commons-httpclient-dev@jakarta.apache.org Received: (qmail 18239 invoked by uid 99); 3 Jul 2004 21:27:40 -0000 X-ASF-Spam-Status: No, hits=0.6 required=10.0 tests=NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [192.18.33.10] (HELO exchange.sun.com) (192.18.33.10) by apache.org (qpsmtpd/0.27.1) with SMTP; Sat, 03 Jul 2004 14:27:36 -0700 Received: (qmail 2240 invoked by uid 50); 3 Jul 2004 21:28:42 -0000 Date: 3 Jul 2004 21:28:42 -0000 Message-ID: <20040703212842.2239.qmail@nagoya.betaversion.org> From: bugzilla@apache.org To: commons-httpclient-dev@jakarta.apache.org Cc: Subject: DO NOT REPLY [Bug 29874] - Auto method retrial broken X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=29874 Auto method retrial broken ------- Additional Comments From olegk@apache.org 2004-07-03 21:28 ------- Mike, What irks me a little is that socket read timeouts on non-idempotent methods must be considered fatal, as an attempt to automatically retry an non-idempotent method may leave the application in an inconsistent state. As HttpClient can't know whether a method or a sequence of methods are idempotent, it should probably assume they are not. In this case rethrowing socket timeout as a recoverable exception sounds wrong, at least from the conceptual standpoint. I do agree that it might make sense to have connect timeouts treated as recoverable exceptions. The trouble is that currently only method execution can be retried automatically, and connection cannot. Mucking around with MethodRetryHandler was a mistake. Its argument sequence is ugly, but not uglier than many other things. It makes sense to defer any changes to it until 4.0 Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org