hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 29874] - Auto method retrial broken
Date Sat, 03 Jul 2004 18:17:35 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=29874>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=29874

Auto method retrial broken





------- Additional Comments From becke@u.washington.edu  2004-07-03 18:17 -------
Hi Oleg,

In regard to making timeout exceptions non-recoverable,  I'm not sure this is right for all
cases.  In the 
example you site I agree that the read timeout should not have caused a retry.  The problem
here was 
not that the Exception was recoverable, but that the requestSent variable was not being set
correctly.  If 
requestSent had been true (which it should have and is now with your patch) the method would
not 
have been retried using the DefaultMethodRetryHandler.  Also, in cases where there is connect
timeout 
it might be nice to have the method retried (configurable).

I would suggest keeping the timeout exceptions recoverable and then adding method params to

configure how the DefaultMethodRetryHandler determines what exceptions to retry on.

Also, in regard to the MethodRetryHandler,  I'm not sure it's worthwhile deprecating retryMethod().
 
Adding a new method already breaks the API.  We might as well just change the original method.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message