hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 16124] - isHttp11 should have HttpClient scope
Date Sun, 02 May 2004 20:00:33 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=16124>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=16124

isHttp11 should have HttpClient scope





------- Additional Comments From becke@u.washington.edu  2004-05-02 20:00 -------
Hi Oleg,

I agree this is not a sexy solution, but I think it's a good one.  I have a few suggestions.

 - HttpMethodBase.getActualVersion() should just return null instead of throwing an exception
I think.  
The actualVersion (effectiveVerson perhaps) is in an undefined state (null) until the method
is executed, 
but I don't think accessing it should be considered an error
 - HostConfiguration.*Version() should probably be synchronized.
 - We should add some more Javadocs to HostConfiguration.*Version() to indicate that it's
used as the 
default version for communicating with the host, but that it can be overidden by setting the
version on 
the method's params.

Thanks for persevering on this one.  It has proven to be more difficult that I think we previously
would 
have guessed. 

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message