hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 28322] - Connection timeout logic redesign
Date Mon, 12 Apr 2004 21:33:59 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=28322>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=28322

Connection timeout logic redesign





------- Additional Comments From olegk@apache.org  2004-04-12 21:33 -------
Hi Sam,
First of all, thanks for inspiring me to fix this problem (and donating initial
reflection code)

> doing don't include the step that uses "SocketFactory.getDefault()".  This
> confused me mostly because getDefault was static, and I didn't realize that it
> was expected that each subclassed SocketFactory would implement it's own
> getDefault behaviour.

AFAIK SocketFactory#getDefaut is the only (standard) way to instantiate a socket
factory. Therefore I thought this step required no explanation. Fixed now

> It also seems a bit odd to use the String equality to test for an exception 
of SocketTimeoutException. 

Fair enough. Fixed. Patch coming.

Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message