hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 10794] - User interaction for authentication
Date Fri, 30 Jan 2004 18:48:56 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10794>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10794

User interaction for authentication





------- Additional Comments From becke@u.washington.edu  2004-01-30 18:48 -------
Oleg,

Overall I think the design is good now.  I have just a few comments on some of the specifics.

 - I would prefer the name CredentialsProvider to CredentialsCallback.  Though callback works,
I 
think provider is a little more standard.
 - Also, I am wondering if the CredentialsCallback.getCredentials() method should be changed
to 
accept an instance of HttpAuthRealm instead of the scheme, host, and port.
 - The callback param is currently assumed to be a Collection, but I wonder if this is really

necessary.  It seems like just a CredentialsCallback should be sufficient, especially since
it can be 
configured on a per method basic.

I haven't had time to look closely at the HttpMethodDirector authentication logic but I think
some 
test cases will take care of that.

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message