hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 24671] - Basic Authentification fails with non-ASCII username/password characters
Date Tue, 09 Dec 2003 14:47:13 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24671>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24671

Basic Authentification fails with non-ASCII username/password characters





------- Additional Comments From olegk@apache.org  2003-12-09 14:47 -------
Mike,
Just a few ideas:

* I think the parameter list of the AuthScheme#authenticate method is getting a
bit too complex. Initially when designing AuthScheme interface I wanted to avoid
its tight coupling with HttpMethod interface. However, since there seems to be
no way around passing HttpMethod parameters to AuthScheme objects, I see no
reason for simply not taking HttpMethod interface as input which would also give
us access to method's path and method name information

So, how about this?

AuthScheme#authenticate(Credentials credentials, HttpMethod method) 
  throws AuthenticationException;

* EncodingUtil renders HttpConstants superfluous. HttpConstants begs to be
deprecated and EncodingUtil should be used consistently throughout HttpClient
base instead. Keeping both classes makes things unnecessarily confusing.

* I feel HTTP_ELEMENT_CHARSET can simply be used instead of CREDENTIAL_CHARSET. 

Otherwise +1 from me

Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message