hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Becke <be...@u.washington.edu>
Subject Re: [PATCH] *Credentials constructors are sloppy
Date Sat, 22 Nov 2003 21:52:43 GMT
Looks good to me.

Mike

On Nov 22, 2003, at 1:00 PM, Oleg Kalnichevski wrote:

> I think that UserNamePasswordCredentials should not allow null user
> name, as well as NTCredentials should not accept null NT domain and
> host. Especially NTCredentials in its present form can be too
> misleading. One may assume that feeding the constructor with null value
> instead of a real domain name will *somehow* make it pick up the actual
> Windows domain name, which is of course not the case.
>
> If there are no objections raised by Tuesday next week, I'll commit the
> patch as is.
>
> Oleg
> <creds.patch>---------------------------------------------------------- 
> -----------
> To unsubscribe, e-mail:  
> commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail:  
> commons-httpclient-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message