hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 24560] - HttpClient loops endlessly while trying to retrieve status line
Date Thu, 13 Nov 2003 19:05:05 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24560>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24560

HttpClient loops endlessly while trying to retrieve status line

olegk@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|Normal                      |Enhancement
             Status|NEW                         |ASSIGNED
           Priority|Other                       |Low
   Target Milestone|---                         |2.1 Beta 1



------- Additional Comments From olegk@apache.org  2003-11-13 19:05 -------
Christian,
I finally found enough time to thoroughly examine your patch. While OK in
general there were a few minor details that I did not quite like:
- Throwing a protocol exception from ResponseConsumedWatcher#responseConsumed
was not such a good idea after all. I think it requires too much of ugly code
for very little (or none at all) practical gains. In my version of the patch
extra response content results in a warning message. No exception is thrown.
- HTTP spec requires that HTTP agents ignore all blank lines that precede the
response status line. In your patch is was not taken into consideration
- I adjusted the new parameters to be more in line with existing parameter
conventions in HttpClient

Bottom line, I did go a bit rough on your patch. Please let me know if these
changes are OK with you or not. If there’s something you do not quite agree
with, let me know

I'll take a closer at your simple HTTP Server stuff a bit later. I am quite
determined to replace the existing SimpleHttpConnection testing framework with a
new one based on your code.

Cheers

Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message