hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: [Https & proxy] Impossible to connect
Date Sat, 08 Nov 2003 11:30:58 GMT
I am +1 on this change. I think it is well justified.

Oleg

On Thu, 2003-11-06 at 09:59, Ortwin Gl├╝ck wrote:
> Roland Weber wrote:
> > Folks, this looks like an API error to me. The protocol security
> > should depend on the actual type of the factory passed to the
> > constructor, not on the type of the variable it is stored in!
> 
> I agree. It is a design error to use polymorphism when the only 
> difference in the method signature is a type within the same class 
> hierarchy. Also the two constructors have duplicate code. The attached 
> patch takes care of the problem in CVS HEAD.
> 
> Odi
> 
> ______________________________________________________________________
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-httpclient-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-httpclient-dev-help@jakarta.apache.org


Mime
View raw message